-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): forward compatibility with sigs.k8s.io/controller-runtime #118
Conversation
This PR unblocks #113 |
1cf7ddf
to
d6f8b80
Compare
and also #109 |
package sigs.k8s.io/controller-runtime/pkg/envtest/printer will be removed in future version. Use ginko/v2 and drop that package https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.0 Signed-off-by: Martin Basti <mbasti@redhat.com>
d6f8b80
to
ac6ea70
Compare
Codecov ReportBase: 70.98% // Head: 70.24% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 70.98% 70.24% -0.75%
==========================================
Files 25 25
Lines 2223 2238 +15
==========================================
- Hits 1578 1572 -6
- Misses 494 512 +18
- Partials 151 154 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I'm not going to fix gitlint by breaking URL into 2 lines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
package sigs.k8s.io/controller-runtime/pkg/envtest/printer will be removed in future version.
Use ginko/v2 and drop that package
https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.0